RFR: 8354248: Open source several AWT GridBagLayout and List tests [v2]
Abhishek Kumar
abhiscxk at openjdk.org
Tue Apr 22 04:37:42 UTC 2025
On Tue, 22 Apr 2025 03:28:38 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Open source these AWT GridBagLayout and List tests:
>>
>> java/awt/GridBagLayout/ComponentShortage/ComponentShortage.java
>> java/awt/List/ListScrollbarCursorTest/ListScrollbarCursorTest.java
>> java/awt/List/ListScrollbarTest/ListScrollbarTest.java
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Update review comments
test/jdk/java/awt/GridBagLayout/ComponentShortage.java line 70:
> 68: robot.waitForIdle();
> 69: robot.delay(1000);
> 70: EventQueue.invokeAndWait(() -> {
I suggest to add a blank line before each `EventQueue.invokeAndWait(() -> {` can be added to separate different operations.
test/jdk/java/awt/GridBagLayout/ComponentShortage.java line 83:
> 81: });
> 82: System.out.println("TextField size after Frame's width reduction : " + size);
> 83: if (size.width < fSize.width - WIDTH_REDUCTION) {
Same here, a blank line between print and if statement.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053312036
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053312794
More information about the client-libs-dev
mailing list