RFR: 8354248: Open source several AWT GridBagLayout and List tests [v2]

Tejesh R tr at openjdk.org
Tue Apr 22 05:01:50 UTC 2025


On Tue, 22 Apr 2025 04:34:02 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update review comments
>
> test/jdk/java/awt/GridBagLayout/ComponentShortage.java line 70:
> 
>> 68:             robot.waitForIdle();
>> 69:             robot.delay(1000);
>> 70:             EventQueue.invokeAndWait(() -> {
> 
> I suggest to add a blank line before each `EventQueue.invokeAndWait(() -> {` can be added to separate different operations.

Updated.

> test/jdk/java/awt/GridBagLayout/ComponentShortage.java line 83:
> 
>> 81:             });
>> 82:             System.out.println("TextField size after Frame's width reduction : " + size);
>> 83:             if (size.width < fSize.width - WIDTH_REDUCTION) {
> 
> Same here, a blank line between print and if statement.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053330115
PR Review Comment: https://git.openjdk.org/jdk/pull/24749#discussion_r2053330186


More information about the client-libs-dev mailing list