RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v8]

[Alexey Ivanov]

On Mon, 21 Apr 2025 17:44:14 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Open-sourced the following Swing tests:
>> 
>> 1. javax/swing/JFileChooser/bug4464774.java
>> 2. javax/swing/JFileChooser/bug4522756.java
>> 3. javax/swing/JFileChooser/bug4759934.java
>> 4. javax/swing/JFileChooser/bug4943900.java
>> 5. javax/swing/JOptionPane/bug4194862.java
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   bug4943900 instruction update

Looks good except for minor nits.

test/jdk/javax/swing/JFileChooser/bug4943900.java line 48:

> 46: 
> 47:         3. Leave the "Text files" item selected and check that the
> 48:         filter works: only *.txt files can appear in the files list

Suggestion:

        filter works: only *.txt files can appear in the file list.

test/jdk/javax/swing/JFileChooser/bug4943900.java line 52:

> 50:         that contains some *.txt files to ensure they are shown in
> 51:         the file list. On macOS when the text filter is applied verify
> 52:         that the non-text files are shown disabled (greyed out).

Suggestion:

        that the non-text files are greyed out.

It's more concise, isn't it?

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24456#pullrequestreview-2784635410
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054432773
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054433891