RFR: JDK-8353486 : Open source Swing Tests - Set 4 [v8]
Alexey Ivanov
aivanov at openjdk.org
Tue Apr 22 16:33:50 UTC 2025
On Tue, 22 Apr 2025 16:11:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> bug4943900 instruction update
>
> test/jdk/javax/swing/JFileChooser/bug4943900.java line 52:
>
>> 50: that contains some *.txt files to ensure they are shown in
>> 51: the file list. On macOS when the text filter is applied verify
>> 52: that the non-text files are shown disabled (greyed out).
>
> Suggestion:
>
> that the non-text files are greyed out.
>
> It's more concise, isn't it?
I meant to add period too, you end the sentence here, and another sentence starts on the next line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24456#discussion_r2054462728
More information about the client-libs-dev
mailing list