RFR: 8355904: Use variadic macros for J2dTrace

Nikita Gubarkov ngubarkov at openjdk.org
Tue Apr 29 13:11:57 UTC 2025


J2dTrace macros have multiple overloads specifying number of arguments, making it less convent to change number of arguments. There were cases when existing macros were not enough and people had to add new variants with even more arguments. We could simply use variadic macros instead.

Also, currently those macros expand to a { code block }, which doesn't require a semicolon at the end, so it can sometimes be missed, leading to an inconsistent code style. We could expand it directly to the function, forcing user to insert a semicolon after that, in a function-like style.

-------------

Commit messages:
 - 8355904: Use variadic macros for J2dTrace

Changes: https://git.openjdk.org/jdk/pull/24949/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24949&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8355904
  Stats: 511 lines in 64 files changed: 0 ins; 99 del; 412 mod
  Patch: https://git.openjdk.org/jdk/pull/24949.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24949/head:pull/24949

PR: https://git.openjdk.org/jdk/pull/24949


More information about the client-libs-dev mailing list