RFR: 8355904: Use variadic macros for J2dTrace [v2]
Nikita Gubarkov
ngubarkov at openjdk.org
Tue Apr 29 14:04:07 UTC 2025
> J2dTrace macros have multiple overloads specifying number of arguments, making it less convent to change number of arguments. There were cases when existing macros were not enough and people had to add new variants with even more arguments. We could simply use variadic macros instead.
>
> Also, currently those macros expand to a { code block }, which doesn't require a semicolon at the end, so it can sometimes be missed, leading to an inconsistent code style. We could expand it directly to the function, forcing user to insert a semicolon after that, in a function-like style.
Nikita Gubarkov has updated the pull request incrementally with one additional commit since the last revision:
fixup! 8355904: Use variadic macros for J2dTrace
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24949/files
- new: https://git.openjdk.org/jdk/pull/24949/files/c17d3c94..867aee60
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24949&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24949&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24949.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24949/head:pull/24949
PR: https://git.openjdk.org/jdk/pull/24949
More information about the client-libs-dev
mailing list