RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v30]
Alexey Ivanov
aivanov at openjdk.org
Mon Aug 11 11:50:25 UTC 2025
On Thu, 26 Jun 2025 14:22:37 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> MenuItem with icon fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java line 723:
>
>> 721: acceleratorSelectionForeground);
>> 722: SwingUtilities3.setAcceleratorForeground(acceleratorForeground);
>> 723: SwingUtilities3.paintAccText(g, lh, lr);
>
> This is a really weird way… Pass the colors explicitly as parameters to the `SwingUtilities3.paintAccText` method.
Again, the comment marked as resolved…
You have changed the implementation in `BasicMenuItemUI` but left it unchanged in other methods.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266463534
More information about the client-libs-dev
mailing list