RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v30]

[Alexey Ivanov]

On Mon, 11 Aug 2025 11:47:36 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java line 723:
>> 
>>> 721:                         acceleratorSelectionForeground);
>>> 722:         SwingUtilities3.setAcceleratorForeground(acceleratorForeground);
>>> 723:         SwingUtilities3.paintAccText(g, lh, lr);
>> 
>> This is a really weird way… Pass the colors explicitly as parameters to the `SwingUtilities3.paintAccText` method.
>
> Again, the comment marked as resolved…
> 
> You have changed the implementation in `BasicMenuItemUI` but left it unchanged in other methods.

It's so confusing! This particular comment hasn't been resolved: you still pass parameters to `SwingUtilities3` via global static variables!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266470220