RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v30]

Alexey Ivanov aivanov at openjdk.org
Mon Aug 11 12:02:25 UTC 2025


On Thu, 26 Jun 2025 14:30:30 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   MenuItem with icon fix
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsMenuItemUI.java line 73:
> 
>> 71:     private static Color disabledForeground;
>> 72:     private static Color acceleratorSelectionForeground;
>> 73:     private static Color acceleratorForeground;
> 
> Why are these needed?
> 
> `BasicMenuItemUI` has fields for all three colors: `disabledForeground`, `acceleratorSelectionForeground`, `acceleratorForeground`. Why do you need to create three *new static* fields instead?

Again this doesn't look right to me and this hasn't been resolved at all. These static variables are present in the class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266488331


More information about the client-libs-dev mailing list