[jdk25] RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel
Phil Race
prr at openjdk.org
Mon Aug 11 15:57:12 UTC 2025
On Sun, 10 Aug 2025 12:58:58 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Hi all,
>
> This pull request contains a backport of commit [e29346db](https://github.com/openjdk/jdk/commit/e29346dbd6328dcadc347a70d8c06ce141efef02) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Prasanta Sadhukhan on 7 Aug 2025 and was reviewed by Phil Race, Alexander Zuev and Abhishek Kumar.
>
>
> The issue is a manual JCK test fails due to lack of demarcation between selected and unselected JRadioButtonMenuItem and JCheckboxMenuItem whereby JDK does not draw bullet/checkmark in WIndows 11 if imgage icon is present as the (position) offset to draw them is same as the image icon position.
> Fix is made to ensure the bullet/checkmark is drawn followed by image icon followed by menu text so that user can distinguish between selected and deselected radiobutton/checkbox menuitem
>
> CI testing and manual conformance test along with SwingSet2 demo testing is ok
src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line 258:
> 256: public static void setAcceleratorSelectionForeground(Color acceleratorSelectionFg) {
> 257: acceleratorForeground = acceleratorSelectionFg;
> 258: }
I just pointed this out on the main bug but this looks like a copy/paste error.
It should be acceleratorSelectionForeground.
To Alexei's point, why can't we pass these as parameters ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26717#discussion_r2267225024
More information about the client-libs-dev
mailing list