[jdk25] RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Aug 12 01:32:58 UTC 2025


On Mon, 11 Aug 2025 15:54:43 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix copy-paste assignment
>
> src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line 258:
> 
>> 256:     public static void setAcceleratorSelectionForeground(Color acceleratorSelectionFg) {
>> 257:         acceleratorForeground = acceleratorSelectionFg;
>> 258:     }
> 
> I just pointed this out on the main bug but this looks like a copy/paste error.
> It should be acceleratorSelectionForeground.
> 
> To Alexei's point, why can't we pass these as parameters ?

Fixed the assignment..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26717#discussion_r2268362347


More information about the client-libs-dev mailing list