RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]
Alexey Ivanov
aivanov at openjdk.org
Mon Aug 18 16:26:10 UTC 2025
On Fri, 15 Aug 2025 22:09:15 GMT, Phil Race <prr at openjdk.org> wrote:
> > > > There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.
> > >
> > >
> > > Yes I do. I overlooked them.
> >
> >
> > If you do, this will resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) that I submitted a few minutes ago.
>
> oh. ok. I guess I will look at your test case and confirm that .. and looks like it is a fully done regression test.
Yes, it is. It was easier to make it a full regression test.
> Maybe you want to push that yourself ?
Yeah, I guess so. I didn't look to update this myself initially. When I left my first comment above, I didn't come up with a test that proves there's a bug even though I had a hunch.
Now I looked at the code and resolved the bug myself. I also submitted my PR that's based on yours.
I edited the subject of the JBS issue that this PR resolves, now it doesn't reference `WindowsMenuItemUI`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26783#issuecomment-3197596934
More information about the client-libs-dev
mailing list