RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

[Alexey Ivanov]

On Fri, 15 Aug 2025 22:09:15 GMT, Phil Race <prr at openjdk.org> wrote:

>>> > There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.
>>> 
>>> Yes I do. I overlooked them.
>> 
>> If you do, this will resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) that I submitted a few minutes ago.
>
>> > > There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.
>> > 
>> > 
>> > Yes I do. I overlooked them.
>> 
>> If you do, this will resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) that I submitted a few minutes ago.
> 
> oh. ok. I guess I will look at your test case and confirm that  .. and looks like it is a fully done regression test.
> Maybe you want to push that yourself ?

@prrace Your latest commit https://github.com/openjdk/jdk/commit/1b676514010e55d0903ba445e5dd806e9f1b862d doesn't address the problem fully, you should also remove `WindowsMenuItemUI.installDefaults`.

I posted a comment where I said that I went ahead and submitted my own PR #26826 to resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625 "Can't change accelerator colors in Windows L&F"). My PR removes the static fields from `WindowsMenuItemUI` and adds the regression test attached to the JBS issue.

I propose you revert commit 1b67651 and integrate this PR in the state it was last week with the updated subject that doesn't mention `WindowsMenuItemUI`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26783#issuecomment-3198134374