RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v3]

Phil Race prr at openjdk.org
Mon Aug 18 19:18:11 UTC 2025


> This refactors some Swing code to pass args instead of using statics
> The bug report suggests some further refactoring which could be considered later, but the most
> important thing to do is to eliminate using statics to pass args.
> I've added one other suggestion from the bug report to have the windows case call SU3 directly rather than via newly added static methods, but for the basic case, I left the pre-existing private instance methods.

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8365389

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/26783/files
  - new: https://git.openjdk.org/jdk/pull/26783/files/a1f59db1..1b676514

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=26783&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26783&range=01-02

  Stats: 16 lines in 4 files changed: 9 ins; 3 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/26783.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26783/head:pull/26783

PR: https://git.openjdk.org/jdk/pull/26783


More information about the client-libs-dev mailing list