RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v2]

[Prasanta Sadhukhan]

On Fri, 15 Aug 2025 22:09:15 GMT, Phil Race <prr at openjdk.org> wrote:

>>> > There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.
>>> 
>>> Yes I do. I overlooked them.
>> 
>> If you do, this will resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) that I submitted a few minutes ago.
>
>> > > There are still static fields to store colors in `WindowsMenuItemUI`, do you want to get rid of those too? My bug report implied removing them, yet currently the static fields with colors remain intact in `WindowsMenuItemUI`.
>> > 
>> > 
>> > Yes I do. I overlooked them.
>> 
>> If you do, this will resolve [JDK-8365625](https://bugs.openjdk.org/browse/JDK-8365625) that I submitted a few minutes ago.
> 
> oh. ok. I guess I will look at your test case and confirm that  .. and looks like it is a fully done regression test.
> Maybe you want to push that yourself ?

> @prrace Your latest commit [1b67651](https://github.com/openjdk/jdk/commit/1b676514010e55d0903ba445e5dd806e9f1b862d) doesn't address the problem fully, you should also remove `WindowsMenuItemUI.installDefaults`.

Shouldn't we keep it in WIndowMenuItemUI 
as in BasicLookAndFeel the fields are initialized as

"MenuItem.disabledForeground", null,
            "MenuItem.acceleratorForeground", menuText,
            "MenuItem.acceleratorSelectionForeground", textHighlightText,

whereas in WIndowsLookAndFeel it is

"MenuItem.disabledForeground", InactiveTextColor,
            "MenuItem.acceleratorForeground", MenuTextColor,
            "MenuItem.acceleratorSelectionForeground", SelectionTextColor,

so I think it would be better to initialize the defaults in the L&F it is currently on

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26783#issuecomment-3204193921