RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v25]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Aug 20 13:18:46 UTC 2025
On Tue, 19 Aug 2025 14:54:16 GMT, Khalid Boulanouare <duke at openjdk.org> wrote:
>> Many Mixing tests failed because the work around click lands on the minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid Boulanouare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 39 additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into jdk-8158801
> - Centers missed frames in the middle of screen
> - Uses KeyboardFocusManager instead of FocusManager
> - Reverted not needed changes
> - Updates copyright years
> - Merge branch 'openjdk:master' into jdk-8158801
> - Centers frames in the middle of the screen
> - Releses latch in case of null ancestor or resizing component
> - Update test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>
> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
> - Update test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>
> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
> - ... and 29 more: https://git.openjdk.org/jdk/compare/5b6059ea...9358a9d8
test/jdk/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java line 83:
> 81: frame.add(cb);
> 82: propagateAWTControls(frame);
> 83: frame.setLocationRelativeTo(null);
setLocationRelativeTo called twice
test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java line 109:
> 107: propagateAWTControls(frame);
> 108: frame.setLocationRelativeTo(null);
> 109: frame.setVisible(true);
same here and setVisible() also called twice
test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java line 86:
> 84: }
> 85: propagateAWTControls(frame);
> 86: frame.setLocationRelativeTo(null);
same here
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2288132826
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2288136750
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2288137872
More information about the client-libs-dev
mailing list