RFR: 8158801: [TEST_BUG] Mixing tests fail because of focus workaround trick [v25]
Khalid Boulanouare
duke at openjdk.org
Fri Aug 22 16:15:09 UTC 2025
On Wed, 20 Aug 2025 13:12:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 39 additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Centers missed frames in the middle of screen
>> - Uses KeyboardFocusManager instead of FocusManager
>> - Reverted not needed changes
>> - Updates copyright years
>> - Merge branch 'openjdk:master' into jdk-8158801
>> - Centers frames in the middle of the screen
>> - Releses latch in case of null ancestor or resizing component
>> - Update test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - Update test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>>
>> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
>> - ... and 29 more: https://git.openjdk.org/jdk/compare/8535362b...9358a9d8
>
> test/jdk/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java line 83:
>
>> 81: frame.add(cb);
>> 82: propagateAWTControls(frame);
>> 83: frame.setLocationRelativeTo(null);
>
> setLocationRelativeTo called twice
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java line 109:
>
>> 107: propagateAWTControls(frame);
>> 108: frame.setLocationRelativeTo(null);
>> 109: frame.setVisible(true);
>
> same here and setVisible() also called twice
Done.
> test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java line 86:
>
>> 84: }
>> 85: propagateAWTControls(frame);
>> 86: frame.setLocationRelativeTo(null);
>
> same here
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2294142587
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2294142232
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2294141744
More information about the client-libs-dev
mailing list