RFR: 8365389: Remove static color fields from SwingUtilities3 and WindowsMenuItemUI [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Aug 21 02:03:53 UTC 2025


On Tue, 19 Aug 2025 20:12:40 GMT, Phil Race <prr at openjdk.org> wrote:

>> This refactors some Swing code to pass args instead of using statics
>> The bug report suggests some further refactoring which could be considered later, but the most
>> important thing to do is to eliminate using statics to pass args.
>> I've added one other suggestion from the bug report to have the windows case call SU3 directly rather than via newly added static methods, but for the basic case, I left the pre-existing private instance methods.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8365389

Marked as reviewed by psadhukhan (Reviewer).

Marked as reviewed by psadhukhan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26783#pullrequestreview-3138785804
PR Review: https://git.openjdk.org/jdk/pull/26783#pullrequestreview-3138787065


More information about the client-libs-dev mailing list