RFR: 8373475: Unintentional format string in logString of AccessInfo.cpp [v2]
Alexey Ivanov
aivanov at openjdk.org
Tue Dec 23 20:14:53 UTC 2025
On Tue, 23 Dec 2025 19:58:12 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> A similar pattern is used elsewhere in this file. And I don't want this fix to become a reworking of this code, because that isn't a goal here.
>
> After reading about fputs, I think this is best. Like you mentioned, no ambiguity since it does not use specifiers. Updated.
> A similar pattern is used elsewhere in this file. And I don't want this fix to become a reworking of this code, because that isn't a goal here.
Indeed, it is.
I agree it's better to keep the code consistent.
At the same time, I think it's worth submitting a bug to simplify usages like that, `fputs` works perfectly for strings that doesn't require any formatting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28950#discussion_r2644171856
More information about the client-libs-dev
mailing list