RFR: 8373475: Unintentional format string in logString of AccessInfo.cpp [v2]
Phil Race
prr at openjdk.org
Tue Dec 23 20:30:56 UTC 2025
On Tue, 23 Dec 2025 20:10:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> After reading about fputs, I think this is best. Like you mentioned, no ambiguity since it does not use specifiers. Updated.
>
>> A similar pattern is used elsewhere in this file. And I don't want this fix to become a reworking of this code, because that isn't a goal here.
>
> Indeed, it is.
>
> I agree it's better to keep the code consistent.
>
> At the same time, I think it's worth submitting a bug to simplify usages like that, `fputs` works perfectly for strings that don't require formatting.
Since Damon already made the change and its just one line I'm fine to keep it but not go looking for more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28950#discussion_r2644188965
More information about the client-libs-dev
mailing list