RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v3]

Alisen Chung achung at openjdk.org
Tue Feb 4 00:27:15 UTC 2025


On Mon, 3 Feb 2025 19:02:30 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> The test instructions say that disabled PopupMenus should not have shortcuts shown, but on MacOS, these shortcuts still appear. When checking native MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the test doesn't modify the popup's shortcuts other than adding the shortcut for `A`, it makes sense that the result matches native behavior. So, I modified the test instructions instead to exclude MacOS from this step.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Separate comment blocks
>  - Add platform conditionals to test instructions

Marked as reviewed by achung (Committer).

test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 86:

> 84:         Menu sm = new Menu("Submenu");
> 85: 
> 86:         // Get things going.  Request focus, set size, et cetera

can just remove this comment since it's an artifact from Applet testing

-------------

PR Review: https://git.openjdk.org/jdk/pull/23402#pullrequestreview-2591429446
PR Review Comment: https://git.openjdk.org/jdk/pull/23402#discussion_r1940307967


More information about the client-libs-dev mailing list