RFR: 8347836: Disabled PopupMenu shows shortcuts on Mac [v3]

Alexander Zuev kizune at openjdk.org
Wed Feb 5 16:59:13 UTC 2025


On Mon, 3 Feb 2025 19:02:30 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> The test instructions say that disabled PopupMenus should not have shortcuts shown, but on MacOS, these shortcuts still appear. When checking native MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the test doesn't modify the popup's shortcuts other than adding the shortcut for `A`, it makes sense that the result matches native behavior. So, I modified the test instructions instead to exclude MacOS from this step.
>
> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Separate comment blocks
>  - Add platform conditionals to test instructions

Marked as reviewed by kizune (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23402#pullrequestreview-2596418929


More information about the client-libs-dev mailing list