RFR: 8349351 : Combine Screen Inset Tests into a Single File

Harshitha Onkar honkar at openjdk.org
Fri Feb 7 17:34:14 UTC 2025


On Fri, 7 Feb 2025 16:34:20 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java line 47:
>> 
>>> 45:     private static final int SIZE = 100;
>>> 46:     // Allow a margin tolerance of 1 pixel due to scaling
>>> 47:     private static final int MARGIN_TOLERANCE = 1;
>> 
>> Since this test is extended to both single and multi monitor, I think tolerance can be increased to 2-3 (considering this test runs on CI now).
>
> Is it needed? If there are no failures, I see no reason to increase the tolerance.

If it test runs fine on CI then it should be okay. Previously, I came across few tests which required increasing tolerance value (although not in this context but particularly for pixel color case).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23449#discussion_r1946905377


More information about the client-libs-dev mailing list