RFR: 8349351 : Combine Screen Inset Tests into a Single File
Alexey Ivanov
aivanov at openjdk.org
Fri Feb 7 19:33:09 UTC 2025
On Fri, 7 Feb 2025 17:29:58 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Is it needed? If there are no failures, I see no reason to increase the tolerance.
>
> If it test runs fine on CI then it should be okay. Previously, I came across few tests which required increasing tolerance value (although not in this context but particularly for pixel color case).
Tolerance when comparing colours is different from comparing sizes.
We know that fractional pixels after scaling up and down may be lost, that's where the tolerance comes from.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23449#discussion_r1947080032
More information about the client-libs-dev
mailing list