RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v3]
Alexey Ivanov
aivanov at openjdk.org
Tue Feb 11 17:26:58 UTC 2025
> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if it's run on Windows XP, for this reason it never runs on modern versions of Windows.
>
> Since Windows XP is obsolete and visual styles cannot be disabled since Windows 8, I removed the OS version check completely.
>
> I captured an image of the panel and analyse colors in the image instead of using `Robot.getPixelColor`; I save the image for reference if the test fails.
>
> The updated test passes in the CI.
Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Merge master
- Update the test summary
- Remove the redundant button
- 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23336/files
- new: https://git.openjdk.org/jdk/pull/23336/files/0349f37a..a03f66df
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23336&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23336&range=01-02
Stats: 31639 lines in 929 files changed: 14138 ins; 10937 del; 6564 mod
Patch: https://git.openjdk.org/jdk/pull/23336.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23336/head:pull/23336
PR: https://git.openjdk.org/jdk/pull/23336
More information about the client-libs-dev
mailing list