RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable [v3]

Sergey Bylokhov serb at openjdk.org
Tue Feb 11 19:01:21 UTC 2025


On Tue, 11 Feb 2025 17:26:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if it's run on Windows XP, for this reason it never runs on modern versions of Windows.
>> 
>> Since Windows XP is obsolete and visual styles cannot be disabled since Windows 8, I removed the OS version check completely.
>> 
>> I captured an image of the panel and analyse colors in the image instead of using `Robot.getPixelColor`; I save the image for reference if the test fails.
>> 
>> The updated test passes in the CI.
>
> Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge master
>  - Update the test summary
>  - Remove the redundant button
>  - 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23336#pullrequestreview-2609736397


More information about the client-libs-dev mailing list