RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v6]

Alexey Ivanov aivanov at openjdk.org
Tue Feb 25 12:09:55 UTC 2025


On Mon, 24 Feb 2025 16:46:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc update
>
> test/jdk/java/awt/color/ICC_ProfileSetNullDataTest.java line 33:
> 
>> 31:  */
>> 32: public final class ICC_ProfileSetNullDataTest {
>> 33:     private static final int[] colorSpace = new int [] {
> 
> Suggestion:
> 
>     private static final int[] colorSpace = new int[] {

In fact, the syntax can be simplified further:

private static final int[] colorSpace = {


There's no need for explicit `new int[]`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1969639009


More information about the client-libs-dev mailing list