RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v6]
Harshitha Onkar
honkar at openjdk.org
Tue Feb 25 18:56:08 UTC 2025
On Mon, 24 Feb 2025 16:48:15 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> javadoc update
>
> test/jdk/java/awt/color/ICC_ProfileSetNullDataTest.java line 48:
>
>> 46: } catch (IllegalArgumentException e) {
>> 47: return;
>> 48: }
>
> The test won't run for **all** the cases if you exit after the first successful case — use `continue`.
Good catch. Moved ` throw new RuntimeException("IllegalArgumentException expected");` within try block so continue no longer required.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1970356654
More information about the client-libs-dev
mailing list