RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v6]

Phil Race prr at openjdk.org
Fri Feb 28 23:47:54 UTC 2025


On Mon, 24 Feb 2025 16:31:58 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc update
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1170:
> 
>> 1168:      * @throws IllegalArgumentException if {@code tagSignature} is not a
>> 1169:      *         signature as defined in the ICC specification.
>> 1170:      * @throws IllegalArgumentException if a content of the {@code tagData}
> 
> This is an existing issue, if it's an issue: should the text say *“**the** content”* instead of *“**a** content”*? @prrace

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1976123856


More information about the client-libs-dev mailing list