RFR: 8339728 : [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class [v2]

[Abhishek Kumar]

On Tue, 24 Dec 2024 19:51:12 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Copyright year and test update
>
> src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java line 3975:
> 
>> 3973:         keyCode = keyStroke.getKeyCode();
>> 3974:         debugString("[INFO]:   Shortcut is: " + Integer.toHexString(keyCode));
>> 3975:         if (keyCode != 0) {
> 
> Why do we need this check? If keyCode is not zero we return keyCode but if it is zero we will still return keyCode because we return zero after the condition.

Yeah, the condition check is not needed. Updated.

> test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java line 37:
> 
>> 35:  * @summary Tests that JAWS announce the shortcuts for JMenuItems.
>> 36:  * @library /java/awt/regtesthelpers
>> 37:  * @build PassFailJFrame
> 
> Since instructions mention JAWS i would either make this test Windows specific or if you want to test t on mac too i would rephrase the instructions so they are not OS specific. Either way will work for me.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1900551704
PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1900551451