RFR: 8339728 : [Accessibility, Windows, JAWS] Bug in the getKeyChar method of the AccessBridge class [v3]

[Abhishek Kumar]

On Fri, 3 Jan 2025 19:32:59 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java line 49:
> 
>> 47:                 3. Navigate the Menu Items by using UP / DOWN arrow key
>> 48:                 4. Press Pass if you are able to hear correct JAWS announcements
>> 49:                    for each menu item shorcut else Fail.
> 
> Suggestion:
> 
>                    for each menu item shortcut else Fail.
> 
> Typo.
> 
> You should probably remove the period… to be consistent. Either add ending punctuation to each instruction item, nor don't add it at all, including the last item.

Updated

> test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java line 107:
> 
>> 105:         menu.add(menuItem7);
>> 106: 
>> 107:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
> 
> You should not define a default close operation for a manual test, the `PassFailJFrame` framework handles closing the test window and fails the test.

Updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1903683465
PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1903683805