RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]
Harshitha Onkar
honkar at openjdk.org
Tue Jan 14 18:11:44 UTC 2025
On Tue, 14 Jan 2025 17:33:52 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 995:
>>
>>> 993: case icSigAbstractClass -> CLASS_ABSTRACT;
>>> 994: case icSigNamedColorClass -> CLASS_NAMEDCOLOR;
>>> 995: default -> throw new IllegalArgumentException("Unknown device class");
>>
>> This will expand the line out of 80 chars per line
>
> Interesting, this exception is not specified for this method.
I have changed it back to "Unknown profile class". For that particular header field ICC Spec doc uses either device class or profile class.
I wanted to be consistent here as well as in [ColorSpace Ln#147](https://github.com/openjdk/jdk/pull/23044/files#r1915377657)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1915380960
More information about the client-libs-dev
mailing list