RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Jan 14 20:06:46 UTC 2025


On Tue, 14 Jan 2025 18:08:03 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Interesting, this exception is not specified for this method.
>
> I have changed it back to "Unknown profile class".  For that particular header field ICC Spec doc uses either device class or profile class.
> I wanted to be consistent here as well as in [ColorSpace Ln#147](https://github.com/openjdk/jdk/pull/23044/files#r1915377657)

> Interesting, this exception is not specified for this method.

What do you mean?

The javadoc is:

     * @throws IllegalArgumentException If the byte array does not contain valid
     *         ICC Profile data

The error message is not specified, the error message can be changed to be more specific to the case where it's thrown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1915530214


More information about the client-libs-dev mailing list