RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files [v7]

GennadiyKrivoshein duke at openjdk.org
Fri Jan 17 11:20:12 UTC 2025


> **Description:**
> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media imageable area values according to the PostScript Printer Description File Format Specification.
> The actual implementation reads X and Y coordinates of the upper right corner of the imageable area as width and height of the imageable area. https://bugs.openjdk.org/browse/JDK-8344119
> 
> **Updates:** 
> Added subtraction of the X and Y coordinates of the lower left corner to fix the width and height values of the imageable area.
> 
> **Tests:**
> Tested with `test/jdk/javax/print/DialogMargins.java` using Brother DCP-T720DW, the test draws a black line along the borders of the imageable area.
> The test was run with the minimum possible margins.
> _Before the fix_: the right and bottom lines are not printed (the right and bottom lines are outside the printable area).
> _After the fix_: all lines are printed.

GennadiyKrivoshein has updated the pull request incrementally with one additional commit since the last revision:

  remove trailing whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22110/files
  - new: https://git.openjdk.org/jdk/pull/22110/files/6e4811e0..1682b903

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22110&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22110&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22110.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22110/head:pull/22110

PR: https://git.openjdk.org/jdk/pull/22110


More information about the client-libs-dev mailing list