RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files [v7]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Jan 21 03:38:47 UTC 2025
On Fri, 17 Jan 2025 11:20:12 GMT, GennadiyKrivoshein <duke at openjdk.org> wrote:
>> **Description:**
>> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media imageable area values according to the PostScript Printer Description File Format Specification.
>> The actual implementation reads X and Y coordinates of the upper right corner of the imageable area as width and height of the imageable area. https://bugs.openjdk.org/browse/JDK-8344119
>>
>> **Updates:**
>> Added subtraction of the X and Y coordinates of the lower left corner to fix the width and height values of the imageable area.
>>
>> **Tests:**
>> Tested with `test/jdk/javax/print/DialogMargins.java` using Brother DCP-T720DW, the test draws a black line along the borders of the imageable area.
>> The test was run with the minimum possible margins.
>> _Before the fix_: the right and bottom lines are not printed (the right and bottom lines are outside the printable area).
>> _After the fix_: all lines are printed.
>
> GennadiyKrivoshein has updated the pull request incrementally with one additional commit since the last revision:
>
> remove trailing whitespace
test/jdk/javax/print/CUPSPrinterImageableAreaTest.java line 121:
> 119: job.setPrintable(new RectPrintable(), pageFormat);
> 120: try {
> 121: job.print();
it now goes to default printer..maybe also give an option to show a printdialog and let user choose the printer..I guess choosing PDF-printer will not show the issue?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22110#discussion_r1923028045
More information about the client-libs-dev
mailing list