RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

[Sergey Bylokhov]

On Fri, 24 Jan 2025 00:41:42 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> @mrserb 
>> The location mentioned in LCMSTransform involves creating a new color space transform using 2 or more profiles and DOES NOT  involve creating or updating a profile. Moreover LCMSTrandorm throws CMMException for invalid rendering intents so this case won't be an issue.
>> 
>>> maybe If the cooked approach always throws an exception and the current approach via "cmsSet" just ignores all errors means we are doing something wrong? Can we ask lcms maintainers why the validation is not done for this methods?
>> 
>> We are choosing to add these validation checks to jdk irrespective for whether lcms validates or not.
>
>>We are choosing to add these validation checks to jdk irrespective for whether lcms validates or not.
> 
> I don't think this is right. It's not a javase spec, and there may be a reason why the most common library for icc profiles accepts thad data. We shouldn't be more strict than that, it will limit java applications compared to the alternatives.

Did the upstream provide any feedback/comments about this validation?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1927936243