RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

Sergey Bylokhov serb at openjdk.org
Fri Jan 24 01:00:50 UTC 2025


On Fri, 24 Jan 2025 00:52:04 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>>>We are choosing to add these validation checks to jdk irrespective for whether lcms validates or not.
>> 
>> I don't think this is right. It's not a javase spec, and there may be a reason why the most common library for icc profiles accepts thad data. We shouldn't be more strict than that, it will limit java applications compared to the alternatives.
>
> Did the upstream provide any feedback/comments about this validation?

BTW
>Typically, the user or application will set the rendering intent dynamically at runtime or embedding time. Therefore, this flag may not have any meaning until the profile is used in some context, e.g. in a DeviceLink or an embedded source profile."

Why this usecase should not be covered by the java? As of the current version of patch it will not be possible to load the profile and then set the intent, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1927939786


More information about the client-libs-dev mailing list