RFR: 6899304 : java.awt.Toolkit.getScreenInsets(GraphicsConfiguration) returns incorrect values [v8]

[anass baya]

On Fri, 31 Jan 2025 02:07:21 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java line 59:
>> 
>>> 57:         GraphicsDevice[] gds = ge.getScreenDevices();
>>> 58:         if (gds.length < 2) {
>>> 59:             System.out.println("It's a multi-screen test... skipping!");
>> 
>> BTW I hope we have a test for insets in a single screen config?
>
> Good point. Yes, I did see a test for Single screen config - `test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java`
> 
> @mrserb @aivanov-jdk May be it can be combined into one single test rather than have two separate tests?

Hello @honkar-jdk, @mrserb ,

Thank you for your review.

I have already discussed this with @aivanov-jdk . We agreed to rename the current test MultiScreenInsetsTest.java to something like ScreenInsetsTest.java, and remove the condition that allows the test to run only with a multi-screen configuration. Additionally, we will remove the test located at test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java.

We also agreed that this change should be handled in a separate bug ticket.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23183#discussion_r1936685768