RFR: 6899304 : java.awt.Toolkit.getScreenInsets(GraphicsConfiguration) returns incorrect values [v8]
Harshitha Onkar
honkar at openjdk.org
Fri Jan 31 20:13:16 UTC 2025
On Fri, 31 Jan 2025 05:03:31 GMT, anass baya <duke at openjdk.org> wrote:
>> Good point. Yes, I did see a test for Single screen config - `test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java`
>>
>> @mrserb @aivanov-jdk May be it can be combined into one single test rather than have two separate tests?
>
> Hello @honkar-jdk, @mrserb ,
>
> Thank you for your review.
>
> I have already discussed this with @aivanov-jdk . We agreed to rename the current test MultiScreenInsetsTest.java to something like ScreenInsetsTest.java, and remove the condition that allows the test to run only with a multi-screen configuration. Additionally, we will remove the test located at test/jdk/java/awt/Toolkit/ScreenInsetsTest/ScreenInsetsTest.java. ( since it is less accurate than MultiScreenInsetsTest.java ).
>
> We also agreed that this change should be handled in a separate bug ticket.
>
> Is it Okay for you to proceed that way ? If yes I will proceed with integration
Sounds good to me
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23183#discussion_r1937933084
More information about the client-libs-dev
mailing list