RFR: 8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java [v3]

Brent Christian bchristi at openjdk.org
Thu Jul 17 00:35:48 UTC 2025


On Wed, 16 Jul 2025 22:34:02 GMT, Phil Race <prr at openjdk.org> wrote:

>> Remove a finalize() method in CGraphicsEnvironment, replacing it with Disposer.
>> 
>> I don't see a way to add a test to verify this clean up.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8362291

Changes requested by bchristi (Reviewer).

src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 98:

> 96:     /** Reference to the display reconfiguration callback context. */
> 97:     private final long displayReconfigContext;
> 98:     private Object disposerReferent = new Object();

`disposerReferent` can be final

src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 147:

> 145: 
> 146:     private static class CGEDisposerRecord implements DisposerRecord {
> 147:         private long displayReconfigContext;

`displayReconfigContext` should be final

-------------

PR Review: https://git.openjdk.org/jdk/pull/26332#pullrequestreview-3027331854
PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2211890827
PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2211889216


More information about the client-libs-dev mailing list