RFR: 8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java [v3]
Phil Race
prr at openjdk.org
Thu Jul 17 21:25:09 UTC 2025
On Thu, 17 Jul 2025 00:32:34 GMT, Brent Christian <bchristi at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8362291
>
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 98:
>
>> 96: /** Reference to the display reconfiguration callback context. */
>> 97: private final long displayReconfigContext;
>> 98: private Object disposerReferent = new Object();
>
> `disposerReferent` can be final
ok
> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 147:
>
>> 145:
>> 146: private static class CGEDisposerRecord implements DisposerRecord {
>> 147: private long displayReconfigContext;
>
> `displayReconfigContext` should be final
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2214338709
PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2214338552
More information about the client-libs-dev
mailing list