RFR: 8210765: Remove finalize method in CStrike.java
Phil Race
prr at openjdk.org
Fri Jul 18 20:58:34 UTC 2025
Remove finalize method from CStrike.java
This one is a bit odd in that there's already a Disposer used - and in fact it involves two classes
CStrikeDisposer.java and its subclass - the nested class CStrike.GlyphInfoCache
CStrike.GlyphInfoCache is tracking all the glyph image references.
CStrikeDisposer has the full set of constructors of its superclass - FontStrikeDisposer including support
for the native context
And if supplied, CStrikeDisposer will call the native method freeNativeScalerContext(long) to free the native context
but that native method does not exist !
And there's no CStrike.GlyphInfoCache constructor which allows it to be specified
So the fix is to add that and call the disposeNativeStrikePtr method instead.
I also rejigged things a little so nativeStrikePtr could be final which is supposed to help with the thread visibility.
-------------
Commit messages:
- 8210765
Changes: https://git.openjdk.org/jdk/pull/26397/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26397&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8210765
Stats: 26 lines in 2 files changed: 4 ins; 12 del; 10 mod
Patch: https://git.openjdk.org/jdk/pull/26397.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26397/head:pull/26397
PR: https://git.openjdk.org/jdk/pull/26397
More information about the client-libs-dev
mailing list