RFR: 8210765: Remove finalize method in CStrike.java [v2]
Phil Race
prr at openjdk.org
Mon Jul 21 16:52:54 UTC 2025
> Remove finalize method from CStrike.java
>
> This one is a bit odd in that there's already a Disposer used - and in fact it involves two classes
> CStrikeDisposer.java and its subclass - the nested class CStrike.GlyphInfoCache
> CStrike.GlyphInfoCache is tracking all the glyph image references.
>
> CStrikeDisposer has the full set of constructors of its superclass - FontStrikeDisposer including support
> for the native context
>
> And if supplied, CStrikeDisposer will call the native method freeNativeScalerContext(long) to free the native context
> but that native method does not exist !
> And there's no CStrike.GlyphInfoCache constructor which allows it to be specified
>
> So the fix is to add that and call the disposeNativeStrikePtr method instead.
>
> I also rejigged things a little so nativeStrikePtr could be final which is supposed to help with the thread visibility.
Phil Race has updated the pull request incrementally with one additional commit since the last revision:
8210765
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26397/files
- new: https://git.openjdk.org/jdk/pull/26397/files/69d1ac65..9993f18d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26397&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26397&range=00-01
Stats: 8 lines in 1 file changed: 4 ins; 4 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/26397.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26397/head:pull/26397
PR: https://git.openjdk.org/jdk/pull/26397
More information about the client-libs-dev
mailing list