RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v5]

[Abhishek Kumar]

On Mon, 21 Jul 2025 07:39:59 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.
>> 
>> 
>>  finally {
>>             EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
>>         }
>>     public static void disposeFrame() {
>>         if (frame != null) {
>>             frame.dispose();
>>             frame = null;
>>         }
>>     }
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8361067: header update

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 2:

> 1: /*
> 2:  * Copyright (c) 2008, 2026, Oracle and/or its affiliates. All rights reserved.

Suggestion:

 * Copyright (c) 2008, 2025, Oracle and/or its affiliates. All rights reserved.

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 29:

> 27:   @bug 6315717
> 28:   @summary verifies that drag events are coming for every button if the property is set to true
> 29:   @run main ExtraButtonDrag

jtreg tag 

/*
  * @test
  * @key headful
  * @bug 6315717
  * @summary verifies that drag events are coming for every button if the property is set to true
  * @run main ExtraButtonDrag
  */

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 50:

> 48:     private static Robot robot;
> 49:     private volatile static boolean dragged = false;
> 50:     private volatile static boolean moved = false;

Suggestion:

    private static volatile boolean dragged = false;
    private static volatile boolean moved = false;

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 75:

> 73:         public void mouseReleased(MouseEvent e) {
> 74:             System.out.println("Released " + e);
> 75:         }

You can remove these two overridden methods, it's not required to implement.

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 190:

> 188:             doTest();
> 189: 
> 190:             System.out.println("Test PASSED");

You may also remove this statement else modify.
Suggestion:

            System.out.println("Test Passed");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241651657
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241674366
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241657947
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241671163
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241689841