RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v5]
Abhishek Kumar
abhiscxk at openjdk.org
Wed Jul 30 06:59:57 UTC 2025
On Mon, 21 Jul 2025 07:39:59 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:
>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.
>>
>>
>> finally {
>> EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
>> }
>> public static void disposeFrame() {
>> if (frame != null) {
>> frame.dispose();
>> frame = null;
>> }
>> }
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>
> 8361067: header update
test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 57:
> 55: @Override
> 56: public void mouseDragged(MouseEvent e) {
> 57: System.out.println("Dragged " + e);
Is it required to log the event ?
Seems too much logging.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2241711182
More information about the client-libs-dev
mailing list