RFR: 8359996: Remove unnecessary List.indexOf key from Track.remove

[Jean-Noël Rouvignac]

On Wed, 23 Apr 2025 17:26:38 GMT, Chen Liang <liach at openjdk.org> wrote:

>> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we can call `List.remove(Object)` directly. It's faster and cleaner.
>> `eventsList` is an ArrayList.
>
> src/java.desktop/share/classes/javax/sound/midi/Track.java line 202:
> 
>> 200:         synchronized(eventsList) {
>> 201:             if (set.remove(event)) {
>> 202:                 if (eventsList.remove(event)) {
> 
> Can be rewritten as `if (set.remove(event) && eventsList.remove(event))`.

`return set.remove(event) && eventsList.remove(event);` even...

And remove the return statement coming after

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24818#discussion_r2130352907