RFR: 8359996: Remove unnecessary List.indexOf key from Track.remove

Alexey Ivanov aivanov at openjdk.org
Thu Jun 19 19:51:30 UTC 2025


On Thu, 5 Jun 2025 20:58:19 GMT, Jean-Noël Rouvignac <duke at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/sound/midi/Track.java line 202:
>> 
>>> 200:         synchronized(eventsList) {
>>> 201:             if (set.remove(event)) {
>>> 202:                 if (eventsList.remove(event)) {
>> 
>> Can be rewritten as `if (set.remove(event) && eventsList.remove(event))`.
>
> `return set.remove(event) && eventsList.remove(event);` even...
> 
> And remove the return statement coming after

This is *cleaner*.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24818#discussion_r2157582518


More information about the client-libs-dev mailing list