RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v4]

Abhishek Kumar abhiscxk at openjdk.org
Thu Jun 19 10:31:31 UTC 2025


On Thu, 19 Jun 2025 09:15:08 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> Use PassFailJFrame to streamline the test java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>> 
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Feedback: Instructions Update

test/jdk/java/awt/print/Dialog/DialogType.java line 52:

> 50:         Two dialogs are shown in succession.
> 51:         The test passes as long as no exceptions are thrown.
> 52:         Note: On Mac OS & on Windows, the first dialog is a native

May add a blank line before Note.
Suggestion:

        The test passes as long as no exceptions are thrown.
        
        Note: On Mac OS & on Windows, the first dialog is a native

test/jdk/java/awt/print/Dialog/DialogType.java line 80:

> 78:         Attribute[] attrs = aset.toArray();
> 79:         for (int i = 0; i < attrs.length; i++) {
> 80:             System.out.println(attrs[i]);

Is it better to log the attributes using PFJ log area ?
or is it really require to log the output ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156677323
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156673475


More information about the client-libs-dev mailing list