RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v4]

Alexey Ivanov aivanov at openjdk.org
Thu Jun 19 19:16:30 UTC 2025


On Thu, 19 Jun 2025 10:26:39 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review Feedback: Instructions Update
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 80:
> 
>> 78:         Attribute[] attrs = aset.toArray();
>> 79:         for (int i = 0; i < attrs.length; i++) {
>> 80:             System.out.println(attrs[i]);
> 
> Is it better to log the attributes using PFJ log area ?
> or is it really require to log the output ?

I believe this logging is done for the purpose of debugging and it not useful for the person running the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2157540417


More information about the client-libs-dev mailing list