RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v4]

[Srinivas Mandalika]

On Thu, 19 Jun 2025 19:13:10 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/java/awt/print/Dialog/DialogType.java line 80:
>> 
>>> 78:         Attribute[] attrs = aset.toArray();
>>> 79:         for (int i = 0; i < attrs.length; i++) {
>>> 80:             System.out.println(attrs[i]);
>> 
>> Is it better to log the attributes using PFJ log area ?
>> or is it really require to log the output ?
>
> I believe this logging is done for the purpose of debugging and it not useful for the person running the test.

Yes, that is correct. The log area is useful when there is a verification step - such as 'live events' tracking and validation that needs to be displayed on the UI and the test is marked as Pass or Fail as per that. 
Here, if the test fails for any reason - identifying that will be in the scope of the debugging the test by looking closely into the JTR - and hence we have the SOP to log it into the jtr file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2158055216